fix: aria-live and aria-describedby on fieldset element. #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-maillot
force-pushed
the
fix/accessibility-fieldset
branch
from
8fdc5da to
878247c
Compare
m-maillot
commented
Jun 20, 2025
| @@ -197,18 +197,11 @@ export const Fieldset = memo( | |||
| <div | |||
| className={fr.cx("fr-messages-group")} | |||
| id={messagesWrapperId} | |||
| aria-live="assertive" | |||
| aria-live={state === "error" ? "assertive" : undefined} | |||
There was a problem hiding this comment.
Le aria-live assertive est à renseigner seulement si c'est une erreur.
|
Désolé pour le délais, je peux pas merge en l'état car ça introduit un breaking change : les id des états |
m-maillot
force-pushed
the
fix/accessibility-fieldset
branch
from
878247c to
4758c34
Compare
|
Merci pour ton retour @ddecrulle. J'ai modifié ma PR pour ne pas avoir d'impact sur les id des états error et success. Cela n'impacte pas le correctif sur le aria-live assertive. |
m-maillot
force-pushed
the
fix/accessibility-fieldset
branch
from
4758c34 to
daafac4
Compare
m-maillot
commented
Jul 3, 2025
| case "success": | ||
| return successDescId; | ||
| case "info": | ||
| return infoDescId; |
There was a problem hiding this comment.
J'ai ajouté un id sur l'info car quand on a une info, il faut la lier avec le aria-describedby
ddecrulle
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.